bit of a refactor #1

Merged

mico merged 4 commits from review into main 2024-10-25 09:13:40 +00:00

Conversation 0 Commits 4 Files Changed 7 +77 -63

yellowBirdy commented 2024-10-25 00:23:44 +00:00

Collaborator

Copy Link

• changed magic numbers into constants
• redefined the multipliers to reduce rounding errors
• factored the structures out to prevent circular deps
• added fuzz to test_1_profits_per_second
• moved performRaid earlier in addUnit to collect extra geld before spending it

- changed magic numbers into constants - redefined the multipliers to reduce rounding errors - factored the structures out to prevent circular deps - added fuzz to `test_1_profits_per_second` - moved `performRaid` earlier in `addUnit` to collect extra geld before spending it

yellowBirdy added 2 commits 2024-10-25 00:23:45 +00:00

bit of a refactor 738378d93e

raid before buy in addUnit 49b7110a6c

mico added 2 commits 2024-10-25 09:13:06 +00:00

Merged latest main a5f1bc7a57

Ran forge fmt + solved client bug with amounts being much too high due to change in contract calculations 7a32129f7e

mico merged commit 4bcf23a9ac into main 2024-10-25 09:13:40 +00:00

mico referenced this issue from a commit 2024-10-25 09:13:41 +00:00

Merge pull request 'bit of a refactor' (#1) from review into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No Label

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: mico/idle_moloch#1

No description provided.